Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AllowNull internal to prevent conflicts #726

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

mkapahnke
Copy link
Contributor

  • Unity uses a version of "netstandard2.1", but already includes the AllowNull attribute
  • This will prevent conflicts with other packages, that might include this attribute as well

@mkapahnke
Copy link
Contributor Author

mkapahnke commented Jul 25, 2023

I guess, that this should not have an affect on other Markdig code.

The only problem would be, if someone uses the Markdig AllowNull.

@coveralls
Copy link

coveralls commented Jul 25, 2023

Pull Request Test Coverage Report for Build 5659390425

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.323%

Totals Coverage Status
Change from base Build 4772706458: 0.0%
Covered Lines: 25978
Relevant Lines: 27233

💛 - Coveralls

@xoofx xoofx merged commit 5e3416f into xoofx:master Aug 4, 2023
1 check passed
@xoofx xoofx added the bug label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants