Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump .NET framework target to net462 #690

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Bump .NET framework target to net462 #690

merged 3 commits into from
Jan 14, 2023

Conversation

iamcarbon
Copy link
Sponsor Contributor

The final OS distribution supporting .NETFramework 4.5.2 has gone out of support. This bumps the library's minimum .NET Framework target to net 4.6.2.

@coveralls
Copy link

coveralls commented Jan 10, 2023

Pull Request Test Coverage Report for Build 3880616906

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 30 (53.33%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 93.292%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Markdig/Syntax/Inlines/ContainerInline.cs 0 1 0.0%
src/Markdig/Syntax/MarkdownObjectExtensions.cs 3 4 75.0%
src/Markdig.Tests/TestDescendantsOrder.cs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
src/Markdig/Helpers/FastStringWriter.cs 1 99.07%
src/Markdig.Tests/TestDescendantsOrder.cs 3 0.0%
Totals Coverage Status
Change from base Build 3743767643: 0.0%
Covered Lines: 25916
Relevant Lines: 27171

💛 - Coveralls

@iamcarbon
Copy link
Sponsor Contributor Author

Ready for review.

src/Markdig/Helpers/ArrayHelper.cs Outdated Show resolved Hide resolved
@MihaZupan
Copy link
Collaborator

cc: @Kryptos-FR

@xoofx xoofx merged commit 78c4efb into xoofx:master Jan 14, 2023
@xoofx
Copy link
Owner

xoofx commented Jan 14, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants