Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop .netcoreapp2.1 target and cross target .net6.0 #591

Merged
merged 7 commits into from
Jan 30, 2022
Merged

Drop .netcoreapp2.1 target and cross target .net6.0 #591

merged 7 commits into from
Jan 30, 2022

Conversation

iamcarbon
Copy link
Sponsor Contributor

@iamcarbon iamcarbon commented Jan 28, 2022 •
edited

.NETCOREAPP2.1 is no longer supported & .NET6.0 will provide us with with 3 years of support.

@xoofx
Copy link
Owner

xoofx commented Jan 28, 2022 •
edited

Many warnings in the logs about:

The type 'MemberNotNullAttribute' in 'D:\a\markdig\markdig\src\Markdig\Polyfills\NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in 'D:\a\markdig\markdig\src\Markdig\Polyfills\NullableAttributes.cs'.

Probably a define not working correctly to exclude it for .NET 6.0

@iamcarbon
Copy link
Sponsor Contributor Author

@xoofx Addressed. Ready for review.

MihaZupan
MihaZupan approved these changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good riddance

@xoofx xoofx merged commit ff89b48 into xoofx:master Jan 30, 2022
@xoofx
Copy link
Owner

xoofx commented Jan 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamcarbon @xoofx @MihaZupan