Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELF refactoring with breaking changes #42

Merged
merged 17 commits into from
Oct 15, 2024
Merged

ELF refactoring with breaking changes #42

merged 17 commits into from
Oct 15, 2024

Conversation

xoofx
Copy link
Owner

@xoofx xoofx commented Oct 13, 2024

Following the lessons learned on supporting PE files, this PR is refactoring the ELF loader to make it more solid and to support full binary roundtrip with ELF binaries.

This is a breaking change, so it will require a bump to 2.0

List of tasks to finish before merging:

  • Update the tests to use Verify instead of relying on readelf
  • Add check for ELF binary roundtrip equality
  • Re-add similar methods ElfFile.AddSection (or ElfFile.AddContent maybe, let's see)
  • Check memory usage and see what can be improved (some stuffs are now using class instead of struct, but it might be better to stick to struct)
  • Update documentation

@xoofx xoofx added the enhancement New feature or request label Oct 13, 2024
@xoofx xoofx added breaking-change This is a breaking change PR and removed enhancement New feature or request labels Oct 15, 2024
@xoofx xoofx merged commit 8c9b157 into master Oct 15, 2024
1 check passed
@xoofx xoofx deleted the elf-refactoring branch October 15, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This is a breaking change PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant