Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zintrepid
Copy link
Contributor

Use uncheckedAssign for object variant assignment

Use uncheckedAssign for object variant assignment
@zintrepid
Copy link
Contributor Author

zintrepid commented Feb 9, 2022

This change or a similar one is what I expect is needed, but it does not actually fix issue #17 until nim-lang/Nim#19266 is fixed. Also, there is some code duplication that I don't like, but I don't know a way to avoid it.

@zintrepid
Copy link
Contributor Author

I just want to update here that until nim-lang/Nim#19266 is fixed, this is untestable. I'm not 100% sure this is the entire fix, either. Perhaps a PR is premature or it could be left open until it can be verified.

@xomachine
Copy link
Owner

OK. I will keep an eye on the related PR in Nim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants