Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am happy with the git work, but still need to do some manual sanity checking, and probably run test suite
@fisker you are totally welcome to change anything here. For example, "use
xo
to lintxo
was lost as collateral damage, but we can restore that. Likewise I think the "ignores" fix you had in the same commit could also be restored.Here, I was just trying to do the cleanest possible revert.
This could be considered like a v0.45.1 but since it's also reverting fisker's fixes, it could also be considered like a v0.43.1. It's a mutant. Probably 0.43.1 would make the most sense. (If review goes well, and sindre wants to publish it, of course)
Closes #599 but also re-opens #583