fix: NAN_MODULE_WORKER_ENABLED

[achille-roussel]

Fixes #203

I followed the recommended fix from nodejs/nan#844 which appears to address the issue in the reported test case and other programs I tested it in.

Let me know if you wish to see something changed.

[achille-roussel]

Any updates?

[achille-roussel]

Hello, would you have any updates to share on this issue?

[Y--]

Sorry for the late follow-up. Could you add a test for this?

[Prinzhorn]

Making a module context aware might require cleanup using node::AddEnvironmentCleanupHook. An example can be seen here: https://github.com/CharlieHess/node-mac-notifier/pull/32/files
I just want to make sure if this lands it will work properly. I'll use node-expat in a worker thread and killing it shouldn't cause memory leaks or crashes or whatnot.

[achille-roussel]

Hey, I have not needed this change (maintained a fork at first, but did not need it anymore either), so I probably won't be finishing this PR.

Thanks for the replies, hopefully it will be useful if someone else runs into a similar issue.

[XDean]

@achille-roussel Why you don't need this change, did you find any workaround? I'm now suffering from the same issue.

[achille-roussel]

We stopped using worker threads in our code so the limitation didn't apply to our case anymore.

[XDean]

We stopped using worker threads in our code so the limitation didn't apply to our case anymore.

So how do you deal with long time work? Now I need the process some large xml files. If I don't use workers threads, How to avoid it block mian thread?