-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: X.L.ConditionalLayout #825
base: master
Are you sure you want to change the base?
Conversation
Provide conditional variants of 'ModifiedLayout' and 'Choose', so that modifications (specific layouts) are only applied when a particular condition is met. Co-authored-by: Tomas Janousek <[email protected]> Co-authored-by: Ivan Malison <[email protected]>
There's a but that I can't figure out right now: Assuming something like myLayout = onWorkspace "4" (tall ||| Full) $ Full ||| tall ||| Mirror tall
where
tall = Tall 1 (3/100) (1/2) one needs to issue five Haven't tried debugging this yet, as its getting late, but perhaps someone else immediately knows what's up. |
Is using |
Also it may be better to leave |
Supersedes #582
What I haven't done, yet we probably should (not necessarily in this PR):
RewriteIfMax
,PreScreen
, andPerWorkspace
with this, which would close Display bug with IfMax, PerScreen, PerWorkspace with decorated layouts #75Provide some QOL functions so that it's easier to write predicates. E.g., I reckon lots of people will want to use a variant ofgets $ find ((t ==) . W.tag) . W.workspaces . windowset
.TODOS:
New module: X.L.ConditionalLayout
Provide conditional variants of 'ModifiedLayout' and 'Choose', so that modifications (specific layouts) are only applied when a particular condition is met.
Co-authored-by: Tomas Janousek [email protected]
Co-authored-by: Ivan Malison [email protected]
Description
Include a description for your changes, including the motivation
behind them.
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: cursory testing on my computer yielded the desired results, though someone else should look at this.
I updated the
CHANGES.md
file