Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caduceus round robin loadbalancing #69

Merged
merged 4 commits into from
Feb 25, 2020

Conversation

kcajmagic
Copy link
Member

This is required for Caduceus PR #106

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #69 into master will increase coverage by 0.46%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   55.59%   56.05%   +0.46%     
==========================================
  Files           8        8              
  Lines         545      553       +8     
==========================================
+ Hits          303      310       +7     
- Misses        238      239       +1     
  Partials        4        4
Impacted Files Coverage Δ
src/talaria/talaria.go 0% <0%> (ø) ⬆️
src/talaria/outbounder.go 93% <100%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba2115...40def3c. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #69 into master will decrease coverage by 3.7%.
The diff coverage is 35.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   56.05%   52.35%   -3.71%     
==========================================
  Files           8        9       +1     
  Lines         553      680     +127     
==========================================
+ Hits          310      356      +46     
- Misses        239      317      +78     
- Partials        4        7       +3
Impacted Files Coverage Δ
workerPool.go 91.42% <ø> (ø)
urlFilter.go 100% <ø> (ø)
metrics.go 100% <ø> (ø)
primaryHandler.go 0% <0%> (ø)
control.go 0% <0%> (ø)
main.go 0% <0%> (ø)
outbounder.go 87.73% <40%> (ø)
deviceStatus.go 49.27% <49.27%> (ø)
dispatcher.go 89.32% <80.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40def3c...8c310b5. Read the comment docs.

Copy link
Member

@schmidtw schmidtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@kcajmagic kcajmagic merged commit dc95e3f into xmidt-org:master Feb 25, 2020
@kcajmagic kcajmagic deleted the customResolve branch February 25, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants