Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Vorbis Read Size to be set by user #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow Vorbis Read Size to be set by user #36

wants to merge 4 commits into from

Commits on Nov 21, 2017

  1. Allow Vorbis Read Size to be set by user 

    * Hooking up Vorbis read callbacks to an HTTP data
provider currently yields a lot of overhead due to
many read requests at 2kB
* Allowing the user to set the vorbis read size
lets backend reads become more efficient by
reading greater chunks at any given time
    @8W9aG
    8W9aG committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    b72cec1 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. Add Sanity Checks for setting the read size 

    * Does not allow read sizes < 1
* Does not allow read sizes above chunk sizes
    @8W9aG
    8W9aG committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    c760fc1 View commit details
    Browse the repository at this point in the history

  2. Add getter for read sizes

    @8W9aG
    8W9aG committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    3ef0b16 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2017

  1. Do not use MIN/MAX for portability reasons 

    * Does not work on windows so well
    @8W9aG
    8W9aG committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    28b8183 View commit details
    Browse the repository at this point in the history