Reuse me stats for lookahead #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially addresses the comments in xiph#2934 by removing the unnecessary field `coded_data.lookahead_me_stats`. This data is never modified between the time it is created in `compute_lookahead_motion_vectors` and the time it is used in `compute_block_importances`, so there is no need to keep a separate copy of it. Instead, we can use the main copy of the data in `fs.frame_me_stats`. Results in ~1% peak memory usage reduction.
|
Does it fix the broken invariant? |
lu-zero
approved these changes
Jun 2, 2022
|
It fixes one usage of it. There's still another usage of I wanted to create this fix separately since the solution for this usage is clear--we can remove it--while the fix for the other usage is unclear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses the comments in #2934 by removing the
unnecessary field
coded_data.lookahead_me_stats. This data is nevermodified between the time it is created in
compute_lookahead_motion_vectorsand the time it is used incompute_block_importances, so there is no need to keep a separate copyof it. Instead, we can use the main copy of the data in
fs.frame_me_stats.Results in ~1% peak memory usage reduction.