Disable unreadable literal lint. #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I suppose. Does it really not have a way to confine it to decimals? |
dwbuiten
approved these changes
Jun 20, 2019
It works OK for decimals but splits hex unnecessarily. If it gets an option for controlling how sensitive it is, we can turn it back on.
tdaede
force-pushed
the
unreadable_literal
branch
from
84fabf1 to
6f3e77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works OK for decimals but splits hex unnecessarily. If it
gets an option for controlling how sensitive it is, we can turn
it back on.