Update for Visual Studio solutions #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
libogg_dynamic.slnandlibogg_static.slntolibogg.sln(instead it uses
DebugandReleasefor static andDebugDLLandReleaseDLLfor dynamic, which is how it's done in opus)I'm pretty sure this is all I changed.
The reason for this change is actually very simple, right now, when you're building opus or vorbis, it can be really cumbersome that there is no guarantee you can build it out-of-the-box, e.g. because it won't find ogg, which makes it hard for people who do not have experience with building libraries.