Skip to content

tools/cmd/resolve: Keep iterating through ref-engines on empty Get #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiekeyang merged 1 commit into from
Sep 23, 2017
Merged

tools/cmd/resolve: Keep iterating through ref-engines on empty Get #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/cmd/resolve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ func resolveCallback(ctx context.Context, allRoots map[string][]refengine.Merkle
logrus.Warn(err)
return nil
}
if len(roots) == 0 {
return nil
}
allRoots[name] = roots
return resolved
}
2 changes: 2 additions & 0 deletions tools/refengine/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import (
type Engine interface {

// Get returns an array of potential Merkle roots from the store.
// When no results are found, roots will be an empty array and err
// will be nil.
Get(ctx context.Context, name string) (roots []MerkleRoot, err error)

// Close releases resources held by the engine. Subsequent engine
Expand Down