Repository navigation
[recipe, hardware] fix: drop the DeepSeek-V4 recipe's vLLM B-preshuffle check that refuses every vLLM on gfx94x - #4
Open
xiaohong42 wants to merge 1 commit into
Open
xiaohong42 wants to merge 1 commit into
xiaohong42 wants to merge 1 commit into
Conversation
xiaohong42
force-pushed
the
rocm-dsv4-veomni-main
branch
from
November 2, 2026 02:15
a9be2dc to
0146022
Compare
…le check that refuses every vLLM on gfx94x Co-authored-by: Cursor <cursoragent@cursor.com>
xiaohong42
force-pushed
the
rocm-dsv4-veomni-main
branch
from
November 2, 2026 02:45
0146022 to
4e3670b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the vLLM check that verl-project#8371 added to
examples/grpo_trainer/run_deepseek_v4_veomni.sh. Where the recipe turns on AITER (gfx94x), it exits unless the installed vLLM definesVLLM_ROCM_DSV4_BPRESHUFFLE. That variable was proposed in vllm-project/vllm#63604, which was closed without being merged, so no vLLM defines it and the recipe refuses every vLLM on gfx94x:Redoing the B-preshuffle when weights are reloaded belongs in vLLM, so the recipe no longer inspects vLLM for it. The requirement in the recipe header goes with the check.
Checklist Before Starting
[{modules}] {type}: {description}Test
On gfx942 with a vLLM that does not define
VLLM_ROCM_DSV4_BPRESHUFFLE, with the trainer launch replaced by anecho: onmainthe recipe exits with the message above (exit code 1); with this PR it reaches the launch and still passesNCCL_DEBUG=VERSIONandVLLM_ROCM_USE_AITER=1to the workers. WithVLLM_ROCM_USE_AITER=0, where the check does not run,mainand this PR print the same launch arguments.bash -npasses.API and Usage Example
No API or config change.
Design & Code Changes
examples/grpo_trainer/run_deepseek_v4_veomni.sh: remove the vLLM check and its requirement in the header. The worker environment block is unchanged.Not changed here:
verl/plugin/platform/platform_rocm.pystill defaultsVLLM_ROCM_DSV4_BPRESHUFFLE=0for the rollout servers. No vLLM reads it, so it has no effect.Checklist Before Submitting
bash -n;check_example_naming.pyandcheck_uv_gpu_only.pypass.ci-requestchannel of the verl Slack workspace.recipesubmodule: not changed.