Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@jbrockmendel
Copy link
Contributor

@xhochy
Copy link
Owner

xhochy commented Sep 16, 2019

This probably should wait until the pandas PR is merged?

@jbrockmendel
Copy link
Contributor Author

This probably should wait until the pandas PR is merged?

This should be correct regardless of if/when 28389 is merged. My preference would be to get it over with, but not gonna lose sleep over waiting a bit.

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #81 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   86.54%   86.67%   +0.13%     
==========================================
  Files          16       16              
  Lines        1159     1163       +4     
==========================================
+ Hits         1003     1008       +5     
+ Misses        156      155       -1
Impacted Files Coverage Δ
fletcher/base.py 94.63% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b8f12...8471c36. Read the comment docs.

Copy link
Owner

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbrockmendel !

@xhochy xhochy merged commit 877d059 into xhochy:master Oct 1, 2019
@jbrockmendel jbrockmendel deleted the easize branch October 1, 2019 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants