Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved RoleGraph error handling, added a "Top 2 levels" select #3667

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

jskupsik
Copy link
Contributor

@jskupsik jskupsik commented May 20, 2024

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@jskupsik
Copy link
Contributor Author

Encountered a role with a 'cycle' in a client dev environment - opening the role in the role manager ui crashed the whole roles ui tab rather than just the chart. Improved the roles chart to catch this exception.

Additionally, I added a switch for showing "only the first two layers" of the Roles grid - a common use case I found myself manually creating by closing every node, and a mode which is immune to the 'cycle' crash.

@lbwexler lbwexler merged commit ea1c7f7 into develop Jun 6, 2024
2 checks passed
@lbwexler lbwexler deleted the rolesGraphCycleCrashFix branch June 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants