Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GridModel bug where Store would fail to recognize dot-separat… #3190

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Fix GridModel bug where Store would fail to recognize dot-separat… #3190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
their drop-down menus.
* Fix desktop styling bug where buttons inside a `Toast` could be rendered with a different color
than the rest of the toast contents.
* Fix `GridModel` bug where `Store` would fail to recognize dot-separated field names as paths
when provided as part of a field spec in object form.

## v53.0.0 - 2022-10-19

Expand Down
2 changes: 1 addition & 1 deletion cmp/grid/GridModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,7 @@ export class GridModel extends HoistModel {
const newFields = [];
forEach(leafColsByFieldName, (col, name) => {
if (name !== 'id' && !storeFieldNames.includes(name)) {
newFields.push({name, displayName: col.displayName, ...col.fieldSpec});
newFields.push({displayName: col.displayName, ...col.fieldSpec, name});
}
});

Expand Down