Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter chooser model now accepts shorthand number inputs #3155

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

jskupsik
Copy link
Contributor

@jskupsik jskupsik commented Oct 7, 2022

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

if (isValidElement(ret)) {
// Prevents [object Object] rendering
ret = renderToStaticMarkup(ret);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially concerned that we were going to emit markup somewhere in the stack, given that the rendering pipeline for FilterChooser is fully React (as opposed to the issue handled by #3154 where we pipe into ag-grid context menus that require strings).

But that point is rendered moot 😁 by the use of stripTags below, which is where we first ended up with [object Object] before this fix.

I thought maybe we could update that to let this method return either a stripped string or an element, but we look to do string-based comparisons downstream so, yeah, we def. need this to return a string

@amcclain amcclain merged commit b02b76d into develop Oct 7, 2022
@amcclain amcclain deleted the filterChooserModelNumberInputs branch October 7, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilterChooserModel doesn't allow for standard hoist numberInput formats
2 participants