Add reaction to jsonField to respond to theme changes, Fixes: #507 (#511

) * Add a reaction to jsonField to respond to theme changes * Minor cleanups
xh · Aug 9, 2018 · 5a901ac · 5a901ac
1 parent 0798f6b
commit 5a901ac
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/desktop/cmp/form/JsonField.js b/desktop/cmp/form/JsonField.js
@@ -47,6 +47,17 @@ export class JsonField extends HoistField {
         editorProps: PT.object
     };
 
+    constructor() {
+        super();
+        this.addReaction({
+            track: () => XH.darkTheme,
+            run: () => {
+                const {editor} = this;
+                if (editor) editor.setOption('theme', XH.darkTheme ? 'dracula' : 'default');
+            }
+        });
+    }
+
     editor = null;
     taCmp = null;
 
@@ -143,7 +154,7 @@ export class JsonField extends HoistField {
 
     // CodeMirror docs: If you dynamically create and destroy editors made with `fromTextArea`
     // ...you should make sure to call `toTextArea` to remove the editor
-    componentWillUnmount() {
+    destroy() {
         if (this.editor) this.editor.toTextArea();
     }