cmd: add LLGo-aware LLDB launcher - #2205
Closed
cpunion wants to merge 9 commits into
Closed
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cpunion
force-pushed
the
codex/llgo-lldb-integration-20260729
branch
from
July 28, 2026 23:15
f5b2ddf to
ca99801
Compare
cpunion
force-pushed
the
codex/llgo-lldb-integration-20260729
branch
from
July 29, 2026 00:58
15fd215 to
223db02
Compare
39 tasks
51 tasks
Collaborator
Author
|
Superseded by #2211, which retains the launcher and acceptance-suite commits and adds the versioned marker/schema contract. Keeping one standalone PR avoids an unnecessary merge dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stock LLDB no longer has a maintained Go language plugin, and upstream requires
an RFC plus a committed long-term maintainer before restoring one. Keep the
LLGo-specific integration in this repository:
llgo lldb, which embeds and loads the LLGo Python adapter withoutdepending on a source checkout;
LLGO_LLDB,-lldb, and LLDB argumentpass-through;
wrapper;
llgonamespace so stock LLDBpandvremain unchanged;
cmd/llgo/lldbtest, with source-linemarkers and explicit Python SB API assertions instead of comment parsing;
llgo lldbon the primarymacOS and Ubuntu jobs.
This does not change LLGo's current DWARF contract: compile units remain
DW_LANG_Cfor stock-LLDB variable visibility, while the LLGo producer andversioned marker select the external adapter. The test suite also verifies that
an ordinary C binary is not identified as LLGo.
Testing
checks
cmd/internal/lldbstatement coverage: 83.9% on both platformsgo test -vet=off -timeout 30m ./...go test ./cmd/llgoandgo build ./...Refs #2154. Follow-ups #2206 and #2211.