Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two new properties: onOpenModal and onCloseModal #77

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Added two new properties: onOpenModal and onCloseModal #77

merged 1 commit into from
Feb 4, 2017

Conversation

chdwlch
Copy link
Contributor

@chdwlch chdwlch commented Jan 28, 2017

I added two function properties that are invoked when the modal appears and disappears off of the screen. I'm working on a time-keeping app that has an array of time pickers. The new properties allow me to change the background color of the currently opened time picker so that the user is able to easily distinguish which input is active.

The function onCloseModal is called at the end of onPressConfirm and onPressCancel.
The function onOpenModal is called at the end of onPressDate.

Also, I believe this might solve issues raised by some users. #72

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.3%) to 96.703% when pulling 846ae35 on TheRealityKing:open/close-modal into 59d414d on xgfe:master.

@feyy
Copy link
Contributor

feyy commented Feb 4, 2017

Great!

@feyy feyy merged commit 0d887db into xgfe:master Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants