Addworker cmd #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks a lot for your contribution. The code looks very good. I tested the code and noticed that your version doesn't run the node provisioning in parallel. When you create a new cluster, it directly starts to provision the last worker node. Consequently, it fails to provision an initial cluster. And a little convention stuff:
As soon the issues are solved, I'll merge this. |
|
Hey, thanks alot for the feedback. I implemented the requested changes, i think it works properly now. |
|
there are some little issues, but I will fix them on my own. LGTM and thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, so this is more proof of concept and pretty much my first Go code at all.
So, room for improvement for sure, but maybe we can make sth of it.
Cheers!
Marian