Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu version for worker nodes #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update ubuntu version for worker nodes #325

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a4f53
Update ubuntu version for worker nodes
mavimo Mar 29, 2020
1b82985
Fixed typo on ubuntu version
mavimo May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/cluster_add_external_worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var clusterAddExternalWorkerCmd = &cobra.Command{
Long: `This lets you add an external server to your cluster.

An external server must meet the following requirements:
- ubuntu 16.04
- ubuntu 18.04
- a unique hostname, that doesn't collide with an existing node name
- accessible with the same SSH key as used for the cluster`,
PreRunE: func(cmd *cobra.Command, args []string) error {
Expand Down Expand Up @@ -67,13 +67,13 @@ An external server must meet the following requirements:
}
}

// check ubuntu 16.04
// check ubuntu 18.04
issue, err := AppConf.SSHClient.RunCmd(externalNode, "cat /etc/issue | xargs")
if err != nil {
return err
}
if !strings.Contains(issue, "Ubuntu 16.04") {
return errors.New("target server has no Ubuntu 16.04 installed")
if !strings.Contains(issue, "Ubuntu 18.0404") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me this had to be changed to "Ubuntu 18.04"

return errors.New("target server has no Ubuntu 18.04 installed")
}

return nil
Expand Down