Fix hcloud controller manager #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #294
In the current version, the "hcloud-controller-manager"-addon wants to update the (non-existing) flannel Daemonset. This has been corrected to canal.
It also tries to use version 1.2.0 of the hcloud-cloud-controller-manager which is not suitable for Kubernetes 1.6. I've pushed this version.
And because thats not enough, there is also a bug in the new cloud-controller-manager deployment spec which requires a "network"-key inside the hcloud secret even if it is not used inside the deployment. I added a workaround to remove this secret from the deployment-spec using a patch-request.
Tested this on my cluster