-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use go.mod for dependencies #181
Conversation
quickly for me what's the deal of choosing go.mod over dep? |
using https://github.com/golang/go/wiki/Modules |
@JohnnyQQQQ imho they should coexist until we drop support for go<1.11 |
@JohnnyQQQQ can you rebase on master (from upstream)? |
@JohnnyQQQQ some reference to make the CI work with Go 1.10 and 1.11 at the same time https://arslan.io/2018/08/26/using-go-modules-with-vendor-support-on-travis-ci/ |
like already discussed with @mavimo I'm ok with dropping support for go <1.11, as we are not in a stable major version >= 1.0.0, and hetzner-kube more a tool than a framework. So IMHO we can bring this PR on go 1.11 only with go mod as one package management solution. |
@JohnnyQQQQ if needed I can work on it, let me know if you have time to complete this task :) |
@mavimo feel free to pick it up, I don't have much time to work on it right now |
No description provided.