Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go.mod for dependencies #181

Closed
wants to merge 2 commits into from
Closed

Conversation

JohnnyQQQQ
Copy link
Collaborator

No description provided.

@xetys
Copy link
Owner

xetys commented Aug 28, 2018

quickly for me

what's the deal of choosing go.mod over dep?

@JohnnyQQQQ
Copy link
Collaborator Author

JohnnyQQQQ commented Aug 28, 2018

using go mod is the official approach introduced in golang 1.11 for handling dependencies and getting rid of the need to have the project in your GOPATH

https://github.com/golang/go/wiki/Modules

@mavimo
Copy link
Collaborator

mavimo commented Aug 28, 2018

@JohnnyQQQQ imho they should coexist until we drop support for go<1.11

@mavimo
Copy link
Collaborator

mavimo commented Aug 29, 2018

@JohnnyQQQQ can you rebase on master (from upstream)?

@mavimo
Copy link
Collaborator

mavimo commented Sep 1, 2018

@JohnnyQQQQ some reference to make the CI work with Go 1.10 and 1.11 at the same time https://arslan.io/2018/08/26/using-go-modules-with-vendor-support-on-travis-ci/

@xetys
Copy link
Owner

xetys commented Nov 13, 2018

like already discussed with @mavimo I'm ok with dropping support for go <1.11, as we are not in a stable major version >= 1.0.0, and hetzner-kube more a tool than a framework.

So IMHO we can bring this PR on go 1.11 only with go mod as one package management solution.

@mavimo
Copy link
Collaborator

mavimo commented Nov 13, 2018

@JohnnyQQQQ if needed I can work on it, let me know if you have time to complete this task :)

@JohnnyQQQQ
Copy link
Collaborator Author

@mavimo feel free to pick it up, I don't have much time to work on it right now

@mavimo
Copy link
Collaborator

mavimo commented Nov 13, 2018

@JohnnyQQQQ 🆗

@JohnnyQQQQ JohnnyQQQQ closed this Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants