fixed issue reporte from gosimple code checker

xetys · Aug 23, 2018 · a7bdad0 · a7bdad0
1 parent 733cf88
commit a7bdad0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/cmd/util.go b/cmd/util.go
@@ -47,7 +47,7 @@ func waitAction(ctx context.Context, client *hcloud.Client, action *hcloud.Actio
 			switch action.Status {
 			case hcloud.ActionStatusRunning:
 				sendProgress(action.Progress)
-				break
+
 			case hcloud.ActionStatusSuccess:
 				sendProgress(100)
 				errCh <- nil

diff --git a/pkg/hetzner/hetzner_provider.go b/pkg/hetzner/hetzner_provider.go
@@ -80,8 +80,7 @@ func (provider *Provider) CreateNodes(suffix string, template clustermanager.Nod
 
 	var nodes []clustermanager.Node
 	for i := 1; i <= count; i++ {
-		var serverOpts hcloud.ServerCreateOpts
-		serverOpts = serverOptsTemplate
+		serverOpts := serverOptsTemplate
 		nodeNumber := i + offset
 		serverOpts.Name = strings.Replace(serverNameTemplate, "@idx", fmt.Sprintf("%.02d", nodeNumber), 1)
 		serverOpts.Datacenter = &hcloud.Datacenter{

diff --git a/pkg/hetzner/hetzner_provider_test.go b/pkg/hetzner/hetzner_provider_test.go
@@ -306,7 +306,7 @@ func TestProviderGetMasterNodeIsMissing(t *testing.T) {
 func TestProviderInitCluster(t *testing.T) {
 	provider := getProviderWithNodes([]clustermanager.Node{})
 
-	provider.InitCluster("cluster-name", "10.0.1.0/24")
+	_, err = provider.GetMasterNode()
 
 	if provider.GetNodeCidr() != "10.0.1.0/24" {
 		t.Error("cluster node cidr is not correctly set")

diff --git a/pkg/hetzner/util.go b/pkg/hetzner/util.go
@@ -55,7 +55,7 @@ func waitAction(ctx context.Context, client *hcloud.Client, action *hcloud.Actio
 			switch action.Status {
 			case hcloud.ActionStatusRunning:
 				sendProgress(action.Progress)
-				break
+
 			case hcloud.ActionStatusSuccess:
 				sendProgress(100)
 				errCh <- nil