Fixes #326 Add option to disable fallback to PureJavaSnappy + doc #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xerial Any chance to get this merged :) ? |
|
@xerial What are your thoughts on this PR? |
|
As discussed in another ticket, I think it should be better to remove the pure-java option entirely. Let me take a look later. |
|
Removing pure-java snappy support in #381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple if condition to disable the fallback to PureJavaSnappy and re-throws the exception if the system property org.xerial.snappy.purejava.fallback is set to false (default value is true to ensure backwards compatibility).