Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original compressed and uncompressed buffer's position #293

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

viirya
Copy link
Contributor

@viirya viirya commented Sep 14, 2021

This fixes #292.

@xerial xerial merged commit 19cfc8d into xerial:master Oct 20, 2021
@xerial
Copy link
Owner

xerial commented Oct 20, 2021

Thanks for the fix! Merged

@wdroste wdroste mentioned this pull request Nov 28, 2021
dongjoon-hyun added a commit to apache/spark that referenced this pull request Feb 1, 2023
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit to apache/spark that referenced this pull request Feb 1, 2023
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 65a1c16)
Signed-off-by: Dongjoon Hyun <[email protected]>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 65a1c16)
Signed-off-by: Dongjoon Hyun <[email protected]>
senthh pushed a commit to acceldata-io/spark3 that referenced this pull request Aug 30, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 65a1c16)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect buffer positions in PureJavaSnappy causes IllegalArgumentException with hadoop-common's SnappyCodec
2 participants