Migrate libbpf #145
Merged
Migrate libbpf #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunholy
reviewed
Aug 19, 2024
Taskfile.yaml
Outdated
| @@ -30,7 +30,7 @@ tasks: | |||
| desc: "Install in KinD cluster" | |||
| cmds: | |||
| - helm repo add xentra https://xentra-ai.github.io/kube-guardian || true | |||
| - helm install kube-guardian xentra/kube-guardian --namespace kube-guardian | |||
| - helm upgrade kube-guardian xentra/kube-guardian --namespace kube-guardian | |||
There was a problem hiding this comment.
Does this assume it has already been installed?
| @@ -3,20 +3,20 @@ ARG DEBIAN_VERSION="11.7" | |||
| FROM --platform=$BUILDPLATFORM ubuntu:24.04 as builder | |||
|
|
|||
| RUN mkdir -p \ | |||
There was a problem hiding this comment.
Can use WORKDIR which creates and sets the dir? Otherwise lets just put it onto the same line.
|
|
||
| COPY linux/amd64/kube-guardian /artifacts/linux/amd64 | ||
| COPY linux/arm64/kube-guardian /artifacts/linux/arm64 | ||
| COPY localbin/kube-guardian /artifacts/localbin |
There was a problem hiding this comment.
Lets use the --chown and --chmod etc on the COPY command to ensure we have correct perms
|
|
||
| FROM debian:${DEBIAN_VERSION}-slim | ||
|
|
||
| RUN apt update -y && apt install libelf-dev -y |
|
|
||
| RUN apt update | ||
| RUN apt-get install -y util-linux iproute2 | ||
| RUN chmod +x /usr/local/bin/kube-guardian |
There was a problem hiding this comment.
Not needed if we use --chmod on the COPY as mentioned earlier.
| #include "vmlinux.h" | ||
| #include <bpf/bpf_helpers.h> | ||
| #include <bpf/bpf_core_read.h> | ||
|
|
There was a problem hiding this comment.
Excessive extra empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.