New release strategy #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xebia-functional/team-ai Ready for review |
nomisRev
reviewed
May 22, 2023
Comment on lines
+3
to
+10
| if [[ $1 == alpha-* ]] | ||
| then | ||
| echo "stage=alpha" >> "$GITHUB_OUTPUT" | ||
| echo "scope=$(echo "$1" | sed 's/alpha-\(.*\)/\1/')" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "stage=$1" >> "$GITHUB_OUTPUT" | ||
| echo "scope=auto" >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
Nit: is there any way to do this in Gradle? 🤔 We could pass ${{ github.event.inputs.stage }} as an Gradle property to the build.
There was a problem hiding this comment.
Probably, yes. I tried it, but I need to get more familiar with Gradle to create custom tasks
There was a problem hiding this comment.
We can take care of it later. It's a bit confusing how to create tasks, sadly it's a lot more complex than just registering a Kotlin function with a Gradle task name 😭
nomisRev
reviewed
May 22, 2023
nomisRev
approved these changes
May 22, 2023
There was a problem hiding this comment.
Thank you @franciscodr! 🙌
Looks good to me, just a couple of nits but nothing critical, or blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes a new release strategy for the library based on a semantic versioning approach.
The version of the library will be one of these four stages:
alpha,beta,rc, andfinalEvery push to the main branch will increase the stage number of the version by one, except for final versions (to avoid unexpected releases of final versions). Some examples of this strategy:
0.0.1-alpha.1->0.0.1-alpha.20.0.1-beta.4->0.0.1-alpha.50.0.1-rc.2->0.0.1-alpha.30.0.1-> it remains unchangedCreating the tag for this new version will trigger a GitHub Actions workflow to publish the artifacts in Sonatype.
Create version tags manually
When we want to change the stage of the version or the version itself, we will have to run the
Create version tag manuallyworkflow. This workflow has several options depending on what we are aiming for.Create a new version
If the current version is final, and we want to start a new development cycle, we have three different choices:
alpha-major:0.0.1->1.0.0-alpha.1alpha-minor:0.0.1->0.1.0-alpha.1alpha-patch:0.0.1->0.0.2-alpha.1Change the stage of the current version
If we want to change the stage of the current version, there are also three different options:
beta:0.0.1-alpha.3->0.0.1-beta.1rc:0.0.1-alpha.2->0.0.1-rc.1final:0.0.1-alpha.2->0.0.1