Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config #7

Merged
merged 4 commits into from
Apr 22, 2023
Merged

Add config #7

merged 4 commits into from
Apr 22, 2023

Conversation

nomisRev
Copy link
Contributor

This PR completes https://app.clickup.com/t/865c5qakc by adding the configuration in a KMP way.

Note: currently browser environment variables are not supported, but we can potentially support this through webpack later.

@nomisRev
Copy link
Contributor Author

@franciscodr @realdavidvega @gutiory @raulraja ready for review.

Copy link
Contributor

@realdavidvega realdavidvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to see Arrow in action here! 😃

@nomisRev nomisRev merged commit 462cb20 into main Apr 22, 2023
@nomisRev nomisRev deleted the add-config branch April 22, 2023 12:03
realdavidvega pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants