Scala direct syntax DSL #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
commented
May 16, 2023
| @@ -57,8 +57,11 @@ inline fun <A> ai(noinline block: suspend AIScope.() -> A): AI<A> = block | |||
| * | |||
| * This operator is **terminal** meaning it runs and completes the _chain_ of `AI` actions. | |||
| */ | |||
| suspend inline fun <A> AI<A>.getOrElse(crossinline orElse: suspend (AIError) -> A): A = | |||
There was a problem hiding this comment.
We weren't using reified here.
| @OptIn(ExperimentalTime::class) | ||
| suspend inline fun <reified A> AI<A>.getOrElse(crossinline orElse: suspend (AIError) -> A): A = | ||
| suspend fun <A> AIScope(block: suspend AIScope.() -> A, orElse: suspend (AIError) -> A): A = |
There was a problem hiding this comment.
We needed a way to construct AIScope from Scala, so it cannot be inline. This method allows us to have an convenient entry point from Scala.
|
@xebia-functional/team-ai This PR is ready for review. I propose we merge this skeleton, so we can continue in parallel on filling in some smaller parts. WDYT? |
juanpedromoreno
approved these changes
May 16, 2023
realdavidvega
approved these changes
May 17, 2023
Yawolf
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.