Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gen models #559

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Update gen models #559

merged 7 commits into from
Nov 24, 2023

Conversation

fedefernandez
Copy link
Contributor

This PR brings some changes:

  • Updates the OpenAI API to the latest version
  • Updates the ApiClient.kt and HttpResponse.kt with the latest changes from use-generated-openai-client branch
  • Maps the API type object to JsonObject. Previously, it was String, which is wrong
  • Incorporate the types AssistantTools and RunStepObjectStepDetails. These types are anyOf; consequently, the generator doesn't generate them correctly.
  • Finally, it adds the possibility of specifying nullable properties. See KMMGeneratorConfig

raulraja
raulraja approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Fede, this looks great!

@fedefernandez fedefernandez merged commit 0db20cf into main Nov 24, 2023
6 checks passed
@fedefernandez fedefernandez deleted the update-gen-models branch November 24, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedefernandez @raulraja