Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize PostgreSQL code #541

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Reorganize PostgreSQL code #541

merged 7 commits into from
Nov 15, 2023

Conversation

franciscodr
Copy link
Contributor

This pull request proposes a few changes for the PostgreSQL integration in Xef:

  • Remove the PostgreSQLXef object in favor of the data class PostgresVectorStoreConfig
  • Provide another function to run the database migrations with Flyway that uses an existing data source
  • Create the Hikari data source used by the Xef server as a resource to release it accordingly once the server is shutdown

Montagon
Montagon approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @franciscodr! Thanks 🚀

@franciscodr franciscodr merged commit 812b744 into main Nov 15, 2023
5 checks passed
@franciscodr franciscodr deleted the reorganize-postgres-settings branch November 15, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montagon Montagon Montagon approved these changes

@javipacheco javipacheco Awaiting requested review from javipacheco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscodr @Montagon