Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface for VectorStoreService #510

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Interface for VectorStoreService #510

merged 4 commits into from
Oct 30, 2023

Conversation

javipacheco
Copy link
Contributor

@javipacheco javipacheco commented Oct 30, 2023 •
edited
Loading

This PR changes the VectorStoreService for implementing the LocalVectorStore and remove the internal coupling to xef-vector-store

raulraja
raulraja previously approved these changes Oct 30, 2023
View reviewed changes
Montagon
Montagon approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@javipacheco javipacheco merged commit 75dde7b into main Oct 30, 2023
5 checks passed
@javipacheco javipacheco deleted the vector-store-service branch October 30, 2023 15:32
gerson24 pushed a commit that referenced this pull request Oct 31, 2023
@javipacheco @gerson24
Interface for VectorStoreService (#510)
3584319 
* Interface for VectorStoreService

* Build fixed

* Loading vector-store by demand

* Removed shadow var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montagon Montagon Montagon approved these changes

@raulraja raulraja raulraja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javipacheco @raulraja @Montagon