Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Embeddings.kt #480

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update Embeddings.kt #480

merged 1 commit into from
Oct 6, 2023

Conversation

rafaparadela
Copy link
Contributor

When I was trying to use addContext in a demo I faced an error that I could reproduce by running this example.

I realized we were ignoring the chunks when embedding but passing all the documents multiple times.

This PR fixes this.

How to reproduce?:

  • Run this example before the change (it won't work)
  • Run this example after the change (it will work)

@rafaparadela rafaparadela merged commit 4e71c37 into main Oct 6, 2023
@rafaparadela rafaparadela deleted the rafaparadela-patch-1 branch October 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intex32 Intex32 Intex32 approved these changes

@fedefernandez fedefernandez fedefernandez approved these changes

@javipacheco javipacheco Awaiting requested review from javipacheco

@raulraja raulraja Awaiting requested review from raulraja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaparadela @fedefernandez @Intex32