Gcp runtime #371
Merged
Gcp runtime #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javipacheco
previously approved these changes
Aug 31, 2023
integrations/gcp/src/commonMain/kotlin/com/xebia/functional/xef/gcp/GcpConfig.kt
Show resolved
Hide resolved
integrations/gcp/src/commonMain/kotlin/com/xebia/functional/xef/gcp/GCP.kt
Outdated
Show resolved
Hide resolved
integrations/gcp/src/commonMain/kotlin/com/xebia/functional/xef/gcp/GCPChatScopeExtensions.kt
Outdated
Show resolved
Hide resolved
Montagon
previously approved these changes
Aug 31, 2023
raulraja
reviewed
Aug 31, 2023
examples/kotlin/src/main/kotlin/com/xebia/functional/xef/conversation/gpc/Chat.kt
Outdated
Show resolved
Hide resolved
raulraja
previously approved these changes
Aug 31, 2023
integrations/gcp/src/commonMain/kotlin/com/xebia/functional/xef/gcp/GCPChatScopeExtensions.kt
Outdated
Show resolved
Hide resolved
openai/src/commonMain/kotlin/com/xebia/functional/xef/conversation/llm/openai/OpenAI.kt
Outdated
Show resolved
Hide resolved
We cannot provide defaults as we need access to the GCP instance (which is not accessible through the conversion). In contrast to OpenAI we have additional parameters "location" and "projectId". |
raulraja
reviewed
Sep 1, 2023
integrations/gcp/src/commonMain/kotlin/com/xebia/functional/xef/gcp/GcpScopeExtensions.kt
Outdated
Show resolved
Hide resolved
raulraja
previously approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Everything looks great, thanks @Intex32 !,
can we rename the functions to not include the Gcp suffix in https://github.com/xebia-functional/xef/pull/371/files#r1312844834 ?
javipacheco
reviewed
Sep 1, 2023
examples/kotlin/src/main/kotlin/com/xebia/functional/xef/conversation/gpc/Chat.kt
Outdated
Show resolved
Hide resolved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework of GCP and Conversation for the 0.0.3 release