Split jdk8 jdk21 #277
Merged
Split jdk8 jdk21 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamariamv
requested review from
a team,
serras and
nomisRev
and removed request for
a team
raulraja
previously approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Looks great @Zevleg .
I think going forward, we have to think of a strategy that isn't repeating all examples.
For the jdk21 and others with LOOM support we should have blocking version of the methods in addition to those that return CompletableFuture.
We are investigating in a different spike how to get rid of most of the Java AIScope wrapping and have those methods exported directly from the xef-core JVM version. If we are able to do that then we can stop wrapping the Kotlin methods in the Scala and Java impls.
anamariamv
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Split Java examples into 2 modules. JDK8 and JDK 21