Java example gpt4all #253
Merged
Java example gpt4all #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ava_exmaples_d_web_search
…ava_exmaples_d_web_search
…-functional/xef into Java_exmaples_d_gpt4all
…ava_exmaples_d_gpt4all
…ava_exmaples_d_gpt4all # Conflicts: # examples/java/src/main/java/com/xebia/functional/xef/java/auto/BreakingNews.java # examples/java/src/main/java/com/xebia/functional/xef/java/auto/DivergentTasks.java # examples/java/src/main/java/com/xebia/functional/xef/java/auto/Markets.java # examples/java/src/main/java/com/xebia/functional/xef/java/auto/MealPlan.java # examples/java/src/main/java/com/xebia/functional/xef/java/auto/Weather.java # java/src/main/java/com/xebia/functional/xef/java/auto/AIScope.java
…ava_exmaples_d_gpt4all
victorcrrd
reviewed
Jul 18, 2023
examples/java/src/main/java/com/xebia/functional/xef/java/auto/gpt4all/Chat.java
Outdated
Show resolved
Hide resolved
gpt4all-kotlin/src/jvmMain/kotlin/com/xebia/functional/gpt4all/port/KotlinPort.kt
Outdated
Show resolved
Hide resolved
java/src/main/java/com/xebia/functional/xef/java/auto/AIScope.java
Outdated
Show resolved
Hide resolved
gpt4all-kotlin/src/jvmMain/kotlin/com/xebia/functional/gpt4all/port/KotlinPort.kt
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/com/xebia/functional/xef/java/auto/gpt4all/Chat.java
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/com/xebia/functional/xef/java/auto/gpt4all/Chat.java
Outdated
Show resolved
Hide resolved
raulraja
requested changes
Jul 19, 2023
There was a problem hiding this comment.
I left some comments regarding dependencies we need to agree on before merging this.
We need to all get on the same page about what role each module serves and how dependencies between modules should be organized.
In my understanding, the goals when it comes to implementing something like this are:
xef-corehas no dependencies and is the base building blocks for other langs- Integrations are developed in Kotlin multiplatform. For example
xef-openai,xef-gpt4allwith proper annotations support like @JvmInline etc. - Functions like
promptStreaming: Flow<String>currently declared in core if they were to be ported over to Java in that case the adapterpromptStreaming: Publisher<String>lives in thexef-javamodule. - Users that want to use something like
gpt4allin Java all they have to do is bring as dependenciesxef-javaandxef-gpt4all. SincepromptStreaming: Pubisher<String>is declared inxef-javaandxef-gpt4allprovidesChatmodel impl then they can just use the function passing in the model or in whichever this function is exposed inxef-java
examples/java/src/main/java/com/xebia/functional/xef/java/auto/gpt4all/Chat.java
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/com/xebia/functional/xef/java/auto/gpt4all/Chat.java
Outdated
Show resolved
Hide resolved
gpt4all-kotlin/src/jvmMain/kotlin/com/xebia/functional/gpt4all/port/KotlinPort.kt
Outdated
Show resolved
Hide resolved
nomisRev
reviewed
Jul 19, 2023
java/src/main/java/com/xebia/functional/xef/java/auto/AIScope.java
Outdated
Show resolved
Hide resolved
…ava_exmaples_d_gpt4all
…ava_exmaples_d_gpt4all # Conflicts: # java/src/main/java/com/xebia/functional/xef/java/auto/AIScope.java
raulraja
reviewed
Jul 23, 2023
examples/java/src/main/java/com/xebia/functional/xef/java/auto/gpt4all/Chat.java
Outdated
Show resolved
Hide resolved
…ava_exmaples_d_gpt4all
…ava_exmaples_d_gpt4all
raulraja
previously approved these changes
Jul 24, 2023
java/src/main/java/com/xebia/functional/xef/java/auto/AIScope.java
Outdated
Show resolved
Hide resolved
raulraja
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't could implement the use of Flow in Java, it seems that Java doesn't support .onCompletion and you have to send a FlowCollector and a Continuation to use .collect(), so because of that I implemented a kotlinPort to use Flow in kotlin and getting the answer in Java.
Ticket Java Example (GPT4ALL)