Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Future API - remove JDK19 restriction support JDK8 #210

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Java Future API - remove JDK19 restriction support JDK8 #210

merged 3 commits into from
Jun 28, 2023

Conversation

nomisRev
Copy link
Contributor

@nomisRev nomisRev commented Jun 27, 2023 •
edited
Loading

This PR shows what Java JDK8 API would look like, such that we can have a discussion on the API itself regardless of how we actually write or achieve the implementation.

The most natural improvement that was omitted here is the ability to provide a custom ExecutorService rather than fixing it to Dispatchers.Default. This was added into the PR.

@nomisRev
Copy link
Contributor Author

Thank you @Zevleg 🙏 I addressed and implemented all your feedback.

@nomisRev nomisRev changed the title Showcase Java futures API Java Future API - remove JDK19 restriction support JDK8 Jun 28, 2023
@nomisRev nomisRev merged commit 76420f6 into main Jun 28, 2023
@nomisRev nomisRev deleted the java-futures branch June 28, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zevleg Zevleg Zevleg left review comments

@diesalbla diesalbla diesalbla approved these changes

@raulraja raulraja Awaiting requested review from raulraja

@Yawolf Yawolf Awaiting requested review from Yawolf

@juanpedromoreno juanpedromoreno Awaiting requested review from juanpedromoreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @diesalbla @Zevleg