Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombineDocsChain + VectorQAChain #21

Merged
merged 11 commits into from
May 3, 2023
Merged

CombineDocsChain + VectorQAChain #21

merged 11 commits into from
May 3, 2023

Conversation

realdavidvega
Copy link
Contributor

@realdavidvega realdavidvega commented May 2, 2023

This PR includes CombineDocsChain and VectorQAChain, which allows to add documents and make contextual questions to the LLM. Unit tests are also included.

Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment, it looks good. Thanks, @realdavidvega!

@realdavidvega realdavidvega changed the title [WIP] QA Chains CombineDocsChain + VectorQAChain May 3, 2023
@realdavidvega
Copy link
Contributor Author

@franciscodr @nomisRev @gutiory ready to review!

Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @realdavidvega. Great work 🙌

@realdavidvega realdavidvega merged commit f806e9d into main May 3, 2023
@realdavidvega realdavidvega deleted the qa-chain branch May 3, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants