-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding xef.java module #197
Conversation
This PR is now ready for review, and ready to be merged. We want to prevent this PR from growing too large, and we need to investigate what we want to do with PDF, etc in terms of architecture. When this is merged we can start porting more Java examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple suggestions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java/src/main/java/com/xebia/functional/xef/java/auto/AIScope.java
Outdated
Show resolved
Hide resolved
511d14a
to
0f01b29
Compare
The idea is to have this in Java:
AIScope
fromxef-core
has been renamed toCoreAIScope
for avoiding name collisions in Java and because it's a piece, from core project, needed for creating/instantiating specific AIScope in other implementations.BaseAIScope
could work too.CoreAIScope
is now anAutoCloseable
object so it can be used with atry-with-resources
form Java.prompt
compiles and is workingpromptMessage
compiles and is workingimage
compiles and is workingpdf
compiles and is workingcontextScope
compiles and is working