Adds a Scala Gradle Module #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will be placing the scala version of the library. Later on the amount of dependencies will be reduced according to the kotlin migration
franciscodr
approved these changes
May 2, 2023
There was a problem hiding this comment.
LGTM, @juanpedromoreno. Are we planning to publish the Scala module in Sonatype? If so, the scala-multiversion plugin has a bug that will add the _3.2 suffix to the artifacts instead of just the major version _3
raulraja
approved these changes
May 2, 2023
There was a problem hiding this comment.
thanks, @juanpedromoreno 🙏 ! next, we need to add the dependency to unwrapped and ensure it works by linking to it here. At that point we are ready to start porting the ai interface over
|
Thanks @franciscodr , yes, eventually it'll be published on Sonatype. I'll ask you later on about how to fix that bug (manually perhaps?). Merging this for now |
juanpedromoreno
added a commit
that referenced
this pull request
May 2, 2023
* Fixes bug in method * Improves method and test coverage * Attempt to run and in the CI pipeline * Fixes format * Apply suggestions from code review - removing redundant syntax Co-authored-by: Juan Pedro Moreno <[email protected]> --------- Co-authored-by: Juan Pedro Moreno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this module, we will place the library's Scala version. Later on, the number of Scala dependencies will be reduced according to the planned kotlin migration.