Cu 861mwhnjx split kotlinx serialization #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
requested review from
serras,
franciscodr,
Yawolf,
juanpedromoreno and
realdavidvega
…:xebia-functional/langchain4k into cu-861mwhnjx-split-kotlinx-serialization
Is the build running for longer than 15m 🤕 |
# Conflicts: # core/src/commonMain/kotlin/com/xebia/functional/xef/auto/ImageGenerationAgent.kt # core/src/commonMain/kotlin/com/xebia/functional/xef/llm/openai/OpenAIClient.kt # scala/src/main/scala/com/xebia/functional/xef/scala/auto/package.scala # settings.gradle.kts
Yawolf
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the
xef-kotlinmodule, which will serve as the new top-level module for Kotlin. Wherexef-coreis going to be reduced in size, and APIsxef-kotlinwill cover the use-cases we have specifically for Kotlin.The goal is that
xef-coreonly contains Java (& Scala) friendly APIs, and thus definitions such ascontext(AIScope)andtypealias AI<A> = context(AIScope) () -> Aare meant forxef-kotlin.