Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more serialization data types #110

Merged
merged 1 commit into from
May 26, 2023

Conversation

necosta
Copy link
Contributor

@necosta necosta commented May 26, 2023

Added support for Array, Seq and Vector.
Any other types can be added by having the user pass the correspondent given instance.

Was also exploring handling some circular references that don't work at the moment.
Example:

case class Person(name: String, children: List[Person])

but gave up. Should be seen as an edge case.

Ready for review.

@necosta necosta requested a review from Yawolf May 26, 2023 06:57
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @necosta !

@juanpedromoreno juanpedromoreno merged commit b8b8f4b into main May 26, 2023
@juanpedromoreno juanpedromoreno deleted the feature/more_serialization_datatypes branch May 26, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants