Improve error reporting when things fail #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realdavidvega
approved these changes
May 25, 2023
There was a problem hiding this comment.
I've also been getting that kind of exceptions lately, much better to have them typed and handled properly.
Thanks @serras!
|
@serras should we not do this as part of the typed errors? |
|
@nomisRev yes, this may need a more proper handling in some way. This was just a quick-and-dirty fix so we can get more information while developing, instead of a generic error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of blindly returning the "cannot deserialize" exception when an error arises in the OpenAI client (for example, because the API key is not valid), handle this and throw our own type of exception.
Ready for review @xebia-functional/team-ai