Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: (csl) Array literals #3292

Merged
merged 7 commits into from
Oct 11, 2024
Merged

backend: (csl) Array literals #3292

merged 7 commits into from
Oct 11, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Oct 11, 2024

Add support for array literals to the printer.

@n-io n-io added minor For minor PRs, easy and quick to review, quickly mergeable backend Compiler backend in xDSL labels Oct 11, 2024
@n-io n-io self-assigned this Oct 11, 2024
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise 👍

xdsl/backend/csl/print_csl.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (c33f7b3) to head (9bb814d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
- Coverage   89.99%   89.99%   -0.01%     
==========================================
  Files         445      445              
  Lines       55749    55751       +2     
  Branches     5367     5368       +1     
==========================================
  Hits        50173    50173              
- Misses       4166     4167       +1     
- Partials     1410     1411       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io merged commit d1f33aa into main Oct 11, 2024
14 checks passed
@n-io n-io deleted the nicolai/csl-const-array branch October 11, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants