-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transforms: (canonicalize) Add full dce #3267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3267 +/- ##
==========================================
+ Coverage 89.93% 89.98% +0.04%
==========================================
Files 443 444 +1
Lines 55569 55628 +59
Branches 8678 5352 -3326
==========================================
+ Hits 49977 50057 +80
- Misses 4162 4174 +12
+ Partials 1430 1397 -33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw this deleted the first riscv.label
as it appears in a dead block. Is this acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! The only label we care about is the one at the start of the block we jump to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I'm just proposing a different name, but otherwise good for me ✅
Co-authored-by: Fehr Mathieu <[email protected]>
cf
filecheck test demonstrating the effect of this change