core: Fix parsing for hex denseAttrs #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakdsci
force-pushed
the
fix-dense-hex-parse
branch
from
7dd5ee7
to
4cc5297
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3239 +/- ##
==========================================
- Coverage 89.91% 89.90% -0.02%
==========================================
Files 440 440
Lines 55290 55347 +57
Branches 8627 8635 +8
==========================================
+ Hits 49716 49761 +45
- Misses 4149 4159 +10
- Partials 1425 1427 +2 ☔ View full report in Codecov by Sentry. |
|
Could you please add a unit test that fails before your patch, and works after? |
|
@superlopuh Added. |
|
Thanks @vinayakdsci @superlopuh ! |
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fixes #2876. The original parsing implementation for hex denseAttrs uses format strings in `struct.unpack_from()`, but the format strings actually do not include the count of the chunks contained in the bytes list. This patch fixes this behavior by embedding the number of chunks in the respective format string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2876.
The original parsing implementation for hex denseAttrs uses format strings in
struct.unpack_from(), but the format strings actually do not include the count of the chunks contained in the bytes list.This patch fixes this behavior by embedding the number of chunks in the respective format string.